Bug #92
source-Who_Called.php may violate standards and practices?
| Status: | Closed | Start: | 05/21/2009 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assigned to: | jacobsj | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta v 2.1.0 |
Description
source-Who_Called.php may violate standards and practices?
Line 5 defines the proper method to call as:
//retreive website contents using get_url_contents($url,$timeout);
Line 28 doesn't seem to do it that way -
$value = get_url_contents($url);
Is this a violation?
Related issues
| blocks Caller ID Superfecta - Feature #70: "Automatic" Support for services which require authentication or token | Closed | 05/17/2009 | 05/22/2009 |
History
Updated by tshif over 2 years ago
source-VoIPCNAM.php also has the same problem. it is not using the $timeout parm when it makes its call. Inst this a violation of standards for data-source scripts?
Updated by tshif over 2 years ago
- Priority changed from Normal to High
- % Done changed from 0 to 20
Wait, is this related to a change in scope for the $timeout variable? Are the instructions at the top of each file WRONG now in that due to a change in scope for that variable its not needed in the call any more? If so, then we should change the instructions...
Updated by jacobsj over 2 years ago
Yes, the instructions are wrong.
$timeout is no longer passed into the function, as passing the same value into the function over and over (because $timeout doesn't change while the script is running) again was redundant.
Updated by jacobsj over 2 years ago
- Status changed from New to Closed
- % Done changed from 20 to 100