Caller ID Superfecta

I'm not exactly sure how Who Called works, and the flags are different. There is a spam flag and a threshold, but they are two seperate fields. I'm not sure if the threshold is meant as a spam threshold, or a threshold for something else. If it is meant as a spam threshold, then I don't see why the fields couldn't be combined.

After looking at the code, the two thresholds are not used in the same way. The Who Called script is looking to see if the threshold is met before it returns a valid response, not a spam indicator. I don't think these should be combined into one field.

What should probably happen, is for someone (whoever wrote the script originally) to add comments in the UI about how the fields will be used. It also seems that you can use whocalled.us without logging in, so I'm not sure what the purpose of login information in our script is for. Perhaps someone can clarify that as well.

Agreed. Ill ask Ward Mundy for more info about this code - I think he wrote this portion.

EMail sent to Ward Mundy asking for feedback and flyout help text.

Received email response from NerdUno. He states klingon888 wrote the whocalled portion - I have sent klingon888 an email asking for input.

tshif wrote:

Received email response from NerdUno. He states klingon888 wrote the whocalled portion - I have sent klingon888 an email asking for input.

Tony - Are you talking about the following :

if ($success=='1') :
if ($score>$WhoCalled_threshold) :

When you do a lookup in Whocalled (try the number below and plug in your name/pass) :

http://whocalled.us/do?action=getScore&name=$WhoCalled_name&pass=$WhoCalled_pass&phoneNumber=8662906227

it returns the following : success=1&score=193

Per the instructions at Whocalled.us, "All actions require name/pass/phoneNumber and return success=0&errorMsg=Some message or success=1"

So, if success=0 means there is an error in the lookup. I wanted to test to make sure the lookup is successful before checking the SPAM threshold, so you can basically hardcode this value.

Hope this makes sense.....Dave.

klingon888 wrote:

http://whocalled.us/do?action=getScore&name=$WhoCalled_name&pass=$WhoCalled_pass&phoneNumber=8662906227

it returns the following : success=1&score=193

What does the score mean? Is the score the number of calls reported as spam? Or the number of people that have reported the Caller ID as that which whocalled.us is reporting? Knowing the relevance of the score here would help here.

This issue is related to:
http://redmine.colsolgrp.net/issues/show/16

This code seems to be performing as expected. Jeremy if you prefer to make changes - just reopen this ticket - otherwise, I say we go with it.