Caller ID Superfecta

This data source doesn't enable report back - which is what community supported sources like this one live on.

It's a SHAME to keep releasing new data sources that should be report-back option enabled, but aren't. Perhaps ukstevef would look at the who called us source and take a stab at deploying this source completely - by including the report-back option.

QS: Basic Pass. This data source is zero emission. Nice job so far.

Being held from live update pending the report back option being added to this data source.

r408 adds report back to the interface - but line 235 could use a programmers attention - I think its all that stands between the data source and release.

It would be nice if this data source could have an option as to weather nor not to report back the SPAM flag (if it has been set by the acquiring data source) as well as the CNAM. Currently, the code only goes so far as to report back CNAM.

Ok - In fact, having read their terms and conditions, they only want to have calls that ARE SPAM reported, unless you are the owner trying to get delisted.

Thats would mean for report back to be enabled for this source, we would have to figure out how report back the SPAM flag(if set by the successful data source), trigger report back (if enabled) ONLY if the CNAM collected is marked as SPAM.

Its sort of something we said we wanted to address - maybe now is the time.

This site is really set up to be more of a SPAM recognition tool than a CNAM source. Your far more likely to get a positive it for a SPAM source than for a non SPAM source.

The data source doesn't seem to set the SPAM flag available to data sources - unless I'm missing something. When it scores the call as SPAM - it sets CallerID = 'Telepest' - and then ends.

I think correct behavior is that it should check number, collect CNAM and SPAM status. If SPAM, it should set the SPAM flag and return the CNAM data it gets from telepest.

Feedback please - I could be seeing this all wrong.

This data source does not return the phrase "not found" when run in debug and the data source returns a negative response.

Additional activity related to this case in PBXIAF forum

Looks like the OP (ukstevef) was not aware of the $spam variable and used $caller_id to report back the telepest status. Ukstevef has uploaded a revised version to PIAF forum here: [[http://pbxinaflash.com/forum/showpost.php?p=56705&postcount=668]] This new version sets the $spam variable and it also sets $caller_id = "telepest" when more detailed CNAM is not available and in the comments asks if that is correct. It is not, $caller_id should be left alone if no CNAM is available IMO.

Also I believe this source needs toggles for user to allow this source to get spam status or CNAM or both.

I was tempted to try to combine the two efforts ukstevef's revision and tshif's revision but too many cooks...

I have merged the changes, not sure how to proceed from here.
The feedback resides in a hidden div, and requires a name, email, comment, and spam score - these will have to be stored as config items I assume.

Excellent Steve and thanks. Ill look at the new commit asap and see if I can help out,

Steve - I misunderstood - thought you had committed your changes.
You can either add them to the SVN, or attach your updated code to this ticket and ask for us to review.
For info on SVN policies - check the wiki

Particularly the first two links on that page.

Thanks for the direction, I will check the wiki for further details on how to behave myself here :-)

Can you review the code that I attached in #12. I am not sure how to send the form data though.

r418 has the report back feature disabled.
This data source is ready for QS.