Bug #320

lower case letters don't work for CID rules

Added by lgaetz over 1 year ago. Updated over 1 year ago.

Status:Closed Start:08/09/2010
Priority:Normal Due date:10/15/2010
Assigned to:lgaetz % Done:

100%
Category:-
Target version:Caller ID Superfecta v 2.2.4 Maintenance Release

Description

Originally posted in PIAF Forum here

Local calls that arrive on my zap trunks have a CID of only 7 digits. I have been struggling with making the superfecta CID rules work by prepending my NPA to the 7 digits so I can get successful lookups. Turns out that this module will only accept uppercase N's and X's for the CID Rules. Up until now I have been rather sloppy about using upper and lower case for dialing rules throughout FreePBX, because they both work.

This is probably not an issue that warrants "fixing" but perhaps a note could be added to the rules description that states uppercase characters only.

History

Updated by tshif over 1 year ago

  • Status changed from New to Reviewed

Updated by tshif over 1 year ago

  • Tracker changed from Feature to Bug

Updated by tshif over 1 year ago

  • Target version changed from Caller ID Superfectav 2.2.3 Maintenance Release to Caller ID Superfecta - Future Versions

Updated by tshif over 1 year ago

  • Status changed from Reviewed to Feedback

I think we should fix this. Its an open case - ready for anyone to step up and make the fix. Whose ready?

Updated by tshif over 1 year ago

So - the root complaint here is that you must use UPPER CASE X, N, and Z, is that correct?

Updated by lgaetz over 1 year ago

I only used N's and X's but you are correct. Problem goes away with all upper case characters. Again not a big problem, just a minor difference from standard FreeBSD behavior. A note will easily cover the issue.

Updated by lgaetz over 1 year ago

lgaetz wrote:
"from standard FreeBSD behavior."
Of course I meant standard FreePBX behavior.

Updated by lgaetz over 1 year ago

Got a working code solution on my system for this.

from filename: /bin/callerid.php

original code:

512                   else if($val == "N")
517                   else if($val == "X")
522                   else if($val == "Z")

revised code:

512                   else if(($val == "N") or ($val == "n"))
517                   else if(($val == "X") or ($val == "x"))
522                   else if(($val == "Z") or ($val == "z"))

As usual I leave here for comment from others, particularly by the original author (jacobsj maybe?)

Updated by lgaetz over 1 year ago

  • Status changed from Feedback to Resolved

Updated by tshif over 1 year ago

Has this been committed?

Updated by tshif over 1 year ago

  • Status changed from Resolved to QA Testing
  • Assigned to set to tshif

Updated by tshif over 1 year ago

  • Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta v 2.2.4 Maintenance Release

Updated by lgaetz over 1 year ago

I have not committed the code changes. I was waiting for comments from others

Updated by tshif over 1 year ago

  • Due date set to 10/15/2010
  • Status changed from QA Testing to Assigned
  • Assigned to changed from tshif to lgaetz
  • % Done changed from 0 to 40

This is a perfect looking solution. I agree, lets deploy it.

Updated by lgaetz over 1 year ago

Changes committed to repository as r264

Updated by tshif over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 40 to 100

accepted for build 2.2.4.

Also available in: Atom PDF