Weather by ZIP Code

mykroft wrote:

I think we need a space after the rm and before the {}: /usr/bin/find /var/lib/asterisk/sounds/tts -name "*.wav" -mtime +1 -exec rm {} \;

I was correct the space after rm and before {}

Are you sure your running 1.1.6? This was corrected in r19 (line 59) , as per Bug ticket #216. Can you compare r19 to what you are running right now?

tshif wrote:

Are you sure your running 1.1.6? This was corrected in r19 (line 59) , as per Bug ticket #216. Can you compare r19 to what you are running right now?

my modules screen says 1.1.6, but my install.php does not have the required space in line 59

mykroft wrote:

tshif wrote:

Are you sure your running 1.1.6? This was corrected in r19 (line 59) , as per Bug ticket #216. Can you compare r19 to what you are running right now?

my modules screen says 1.1.6, but my install.php does not have the required space in line 59

i just downloaded the module file again, and took at look at the install.php, and the space is missing - so somehow the file got reverted to its old state

Well Darn. Ok - well fix it again, till it stays fixed. :)

I just triple checked every thing in the svn, the module, and everywhere else I could think - and this error is not present in whats being distributed with the current version.

Please - try UNINSTALLING the module - going even to the point of removing the WEATHERZIP module directory, and then reinstall the current version. Then examine the code and see if the space is missing. Somethings not right - and Id like to understand it better. I honestly cant find this error anywhere alive in the current codebase.

tshif wrote:

I just triple checked every thing in the svn, the module, and everywhere else I could think - and this error is not present in whats being distributed with the current version.

Please - try UNINSTALLING the module - going even to the point of removing the WEATHERZIP module directory, and then reinstall the current version. Then examine the code and see if the space is missing. Somethings not right - and Id like to understand it better. I honestly cant find this error anywhere alive in the current codebase.

I just downloaded 1.1.6 from the site, and even before installing it - examined install.php and it has the following sql line for the cronjob:

$sql = "INSERT INTO    cronmanager (module,id,time,freq,command) VALUES ('weatherzip','every_day',23,24,'/usr/bin/find /var/lib/asterisk/sounds/tts -name \"*.wav\" -mtime +1 -exec rm{} \\\;')";

as you can see, there is no space between the rm and {}, this is what is getting installed on a new install, is the 1.1.6.tgz build not updated by chance?

ok, further testing as you requested:

uninstalled module
removed /var/www/html/admin/modules/weatherbyzip
checked sql cronmanager database - cron line is gone
manually uploaded 1.1.6 i just downloaded
installed module
check sql cronmanager database - cron line is there, but space is missing between rm{}

so it must have gotten to the svn, but not made it into the latest release avail for download......?

You are sadly correct. Its been corrected for the next build. 1.1.7