Caller ID Superfecta

I published the source here : http://pbxinaflash.com/forum/showthread.php?t=4387&page=53

zorka - wow another great source. Could you please go ahead and upload it to the SVN - well get it published in live update right away. THAANKS for all the super contributions to data sources!

Added to svn in r254. Awaiting testing before adding to live update.

I'd like to release this data source - but we need someone to help test it. Any takers?

FreePBX 2.6.0.3 and Superfecta 2.2.3.4
Tried dozens of numbers (all businesses) taken from random google searches (because I don't get many Dutch callers here) and it works very well in debug mode. Most searches are fast say less than 2 sec. but it would occasionally time out even with the timeout bumped way up to 10 seconds, but that must be a problem with the site not the code.

I see that this code has been languishing for 9 months waiting for someone to do some simple testing. When it comes to individual lookup sources, would it not be better to release the code untested and then respond to feedback from users, rather than keep it hidden for so long? I am thinking particularly for sources like Argentina and Serbia where there are not likely to be lots of users, let alone testers.

QS: Basic pass. No unexpected results, source returns data.

lgaetz wrote:

FreePBX 2.6.0.3 and Superfecta 2.2.3.4 Tried dozens of numbers (all businesses) taken from random google searches (because I don't get many Dutch callers here) and it works very well in debug mode. Most searches are fast say less than 2 sec. but it would occasionally time out even with the timeout bumped way up to 10 seconds, but that must be a problem with the site not the code.

I see that this code has been languishing for 9 months waiting for someone to do some simple testing. When it comes to individual lookup sources, would it not be better to release the code untested and then respond to feedback from users, rather than keep it hidden for so long? I am thinking particularly for sources like Argentina and Serbia where there are not likely to be lots of users, let alone testers.

Thanks for the testing. Agreed with your assertion that its the site or connectivty rather than a Superfecta issue when it times out.

Also agreed - datasources can be updated live so the QS phase can be far shorter. Still - a basic amount of testing to assure there isnt some unexpected result that can interfere with a pbx's general operations is called for. Untill you jumped in and did that - it could be viewed as irresponsible to release it. The SVN (even vai web) is available for read only access by the unauthenticated public - so those willing to run wihtout basic QS could have done so. Its an imperfect process - but I think it works for the most part.

tshif wrote:

Until you jumped in and did that - it could be viewed as irresponsible to release it.

It works for Microsoft, should we strive for better?

Hehehe. Oh good heavens yes.
I am not personally satisfied with how the Asterisk Developers or FreePBX team handles backwards compatibility. I think we really NEED to do better.

Infrastructure items, like PBX's go YEARS without updating their core. There are FreePBX installations in LARGE numbers still running 2.6.x to great effect.

It just seems like a bad idea for us to allow Superfecta to become impossible to use without the latest and greatest underpinnings (FreePBX, etc.). Even when we require certain php functions that are not included in "typical" distributions - its a balancing act between wanting to give the developers the tools they need to do great things - and not making the modules infrastructure requirements (php version and function support, FreePBX version) too exacting for mass acceptance or the less technically adept to achieve.

All that being said - I can be wrong - so by all means everyone feel free to continue to keep this discussion point going.

tshif wrote:

All that being said - I can be wrong

You are preaching to the choir here. I am running Asterisk 1.4 and FreePBX 2.6 and won't be changing anytime soon

I know this issue is closed, but I suggest that this data soruce be renamed to be more in line with the current naming scheme. It is currently called source-Netherlands.php and will conflict (if only slightly) with any future ductch sources. Probalby best to do this before final release of 2.2.4

Please provide a naming recommendation.

Renamed source to nummerchecker_NL. Tested Ok.