Caller ID Superfecta

Guys,

Well done on Superfecta 2.2.2. It seems to be a step in the right direction, however a few things appear broken.

On the UK sources for spam filtering, it appears that someone has removed the 02030 - 02039 range from the CLI check (admittedly VoIP), this causes my business number to fail the match. Can these be added back to the two spam sources that I contributed? (
source-PhoneLookup_UK.php and source-PhoneSpamFilter_UK.php)

Additionally, the UkPhoneInfo source seems to cause the insertion of an non-printable number which causes failures. This bug was present within v 2.2.0 and v2.2.1. I'm not entirely convinced that the problem lies within the source as the data leaving the source script appears to be sane.

The problem
-----------

When I enable the source-UKPhoneInfo_UK.php I get a problem in that not all phones receive the call, and of those that do they fail to recognise the hangup signal.

On closer investigation I noted that the debug trace seems to work without fault, but on incoming dial the logs indicate that there is a strange character before the CallerID reported by Superfecta. This may well just be a carriage return, I'm not sure.

It seems to confuse the extensions and cause some to ignore the call and others fail to process further commands from the SIP session (and recognise a hangup).

Is anyone able to replicate this?

Debug traces of problem to follow - with my business number obscured.

Pass
----

-- Executing [2099@ext-group:1] Macro("IAX2/217.14.138.16:4569-13280", "user-callerid|") in new stack
    -- Executing [s@macro-user-callerid:1] Set("IAX2/217.14.138.16:4569-13280", "AMPUSER=020305xxxxx") in new stack
    -- Executing [s@macro-user-callerid:2] GotoIf("IAX2/217.14.138.16:4569-13280", "0?report") in new stack
    -- Executing [s@macro-user-callerid:3] ExecIf("IAX2/217.14.138.16:4569-13280", "1|Set|REALCALLERIDNUM=020305xxxxx") in new stack
    -- Executing [s@macro-user-callerid:4] Set("IAX2/217.14.138.16:4569-13280", "AMPUSER=") in new stack
    -- Executing [s@macro-user-callerid:5] Set("IAX2/217.14.138.16:4569-13280", "AMPUSERCIDNAME=") in new stack
    -- Executing [s@macro-user-callerid:6] GotoIf("IAX2/217.14.138.16:4569-13280", "1?report") in new stack
    -- Goto (macro-user-callerid,s,10)
    -- Executing [s@macro-user-callerid:10] GotoIf("IAX2/217.14.138.16:4569-13280", "0?continue") in new stack
    -- Executing [s@macro-user-callerid:11] Set("IAX2/217.14.138.16:4569-13280", "__TTL=64") in new stack
    -- Executing [s@macro-user-callerid:12] GotoIf("IAX2/217.14.138.16:4569-13280", "1?continue") in new stack
    -- Goto (macro-user-callerid,s,19)
    -- Executing [s@macro-user-callerid:19] NoOp("IAX2/217.14.138.16:4569-13280", "Using CallerID "London" <020305xxxxx>") in new stack

Fail
----

-- Executing [2099@ext-group:1] Macro("IAX2/77.240.48.141:4570-5440", "user-callerid|") in new stack
    -- Executing [s@macro-user-callerid:1] Set("IAX2/77.240.48.141:4570-5440", "AMPUSER=020305xxxxx") in new stack
    -- Executing [s@macro-user-callerid:2] GotoIf("IAX2/77.240.48.141:4570-5440", "0?report") in new stack
    -- Executing [s@macro-user-callerid:3] ExecIf("IAX2/77.240.48.141:4570-5440", "1|Set|REALCALLERIDNUM=020305xxxxx") in new stack
    -- Executing [s@macro-user-callerid:4] Set("IAX2/77.240.48.141:4570-5440", "AMPUSER=") in new stack
    -- Executing [s@macro-user-callerid:5] Set("IAX2/77.240.48.141:4570-5440", "AMPUSERCIDNAME=") in new stack
    -- Executing [s@macro-user-callerid:6] GotoIf("IAX2/77.240.48.141:4570-5440", "1?report") in new stack
    -- Goto (macro-user-callerid,s,10)
    -- Executing [s@macro-user-callerid:10] GotoIf("IAX2/77.240.48.141:4570-5440", "0?continue") in new stack
    -- Executing [s@macro-user-callerid:11] Set("IAX2/77.240.48.141:4570-5440", "__TTL=64") in new stack
    -- Executing [s@macro-user-callerid:12] GotoIf("IAX2/77.240.48.141:4570-5440", "1?continue") in new stack
    -- Goto (macro-user-callerid,s,19)
    -- Executing [s@macro-user-callerid:19] NoOp("IAX2/77.240.48.141:4570-5440", "Using CallerID " 
London" <020305xxxxx>") in new stack

The fail causes
---------------

-- Called 2000
    -- Called 2001
    -- Called 2025
    -- Called 2030
    -- Called 2035
    -- Started music on hold, class 'amigamusic', on IAX2/77.240.48.141:4570-5440
    -- SIP/2001-092f5560 is ringing
    -- SIP/2025-094d60c8 is ringing
    -- SIP/2035-0946f9a8 is ringing
    -- SIP/2030-09293dc0 is ringing
    -- Got SIP response 400 "Bad Request" back from 192.168.0.202
    -- SIP/2000-092c0510 is circuit-busy

Debug
-----
Processing Default Scheme.
Searching Superfecta Cache ... London
result took 0.0041 seconds.

Searching SugarCRM ... not found
result took 0.0089 seconds.

Searching Asterisk Phonebook ... not found
result took 0.0026 seconds.

Searching PhoneSpamFilter (UK) ... value of 0 returned ... Not a SPAM caller
result took 0.7038 seconds.

Searching UK Phone Lookup ... value of 0 returned ... Not a SPAM caller
result took 0.5118 seconds.

Looking for Provided Caller ID ... not found
result took 0.0033 seconds.

Post CID retrieval processing.

Returned Result would be: London
result took 0.0560 seconds.