Feature #224
Ignore on line update check (if enabled) during debug runs
| Status: | Closed | Start: | 10/30/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | 11/01/2009 | |
| Assigned to: | tshif | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfectav 2.2.3 Maintenance Release |
Description
As the system is architected today, if the check for on line updates function, is enabled when debug is pressed, the system checks for updates again.
Since this modification was made, its no longer a benefit for the system to check for updates (if the check mark is enabled) each time the debug button is pressed.
This behavior in fact can be viewed as negative - since it adds nothing to the user experience, but it DOES place extra load on the update server.
Please change the DEBUG behavior so when the debug button is pressed, it does not contact the update server needlessly.
Do not turn off the update check mark - just ignore its enabled status during debug operations.
History
Updated by tshif 9 months ago
- Subject changed from Ignore online update check (if enabled) during debug runs to Ignore on line update check (if enabled) during debug runs
Updated by patrick_elx 9 months ago
Instead of having a checkbox for checkupdate, why not replacing it by a button?
What would be the reason to have a checkbox if it's not to check it all the time?
The replacement by a button is an easy fix.
If you just want to keep it as is, but remove the check on debug, then in sources.php you need to replace the line
if($check_updates 'on')
by something like
if(($check_updates 'on')&&($Debug != 'yes'))
Updated by tshif 9 months ago
Well if we replace by button, they have to push again if they have mutiple source to update. This is not so good.
The second method would be best. Just ignore the update process if the debug button is in use.
Updated by tshif 9 months ago
Tested. Fail. It still seems to be performing the update check. Whenthe site is disabled, it still posting the red warnging - this suggests its still contacting the update site during DEBUG ops.
Thoughts?
Updated by tshif 9 months ago
- Status changed from Reviewed to QA Testing
- Assigned to set to tshif
- % Done changed from 0 to 90
I must apologize - I had a testing anomoly. This patch DOES appear to work as desired.