Bug #220

clean up code

Added by tshif over 2 years ago. Updated over 1 year ago.

Status:Closed Start:10/21/2009
Priority:Normal Due date:
Assigned to:- % Done:

100%

Category:-
Target version:Caller ID Superfecta v 2.2.4 Maintenance Release

Description

callerid is still returning a lot of warning in the error log. Not a big deal as it's still working properly, but maybe a cleanup is needed.
The following is the error log for one lookup.

 1 [error]PHP Notice:  Undefined index:  scheme in callerid.php on line 20
 2 [error]PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 689
 3 [error] PHP Warning:  Invalid argument supplied for foreach() in callerid.php on line 692
 4 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 714
 5 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 689
 6 [error] PHP Warning:  Invalid argument supplied for foreach() in callerid.php on line 692
 7 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 714
 8 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 689
 9 [error] PHP Warning:  Invalid argument supplied for foreach() in callerid.php on line 692
10 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 714
11 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 689
12 [error] PHP Warning:  Invalid argument supplied for foreach() in callerid.php on line 692
13 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 714
14 [error] PHP Notice:  Undefined variable: first_caller_id in callerid.php on line 275
15 [error] PHP Warning:  split() [<a href='function.split'>function.split</a>]: REG_BADRPT in callerid.php on line 689
16 [error] PHP Warning:  Invalid argument supplied for foreach() in callerid.php on line 692
17 [error] PHP Notice:  Undefined index:  From US_Asterisk_Phonebook in callerid.php on line 237
18 

History

Updated by tshif over 2 years ago

  • Status changed from New to Reviewed

Updated by tshif about 2 years ago

  • Status changed from Reviewed to Assigned
  • Priority changed from Low to Normal

Updated by jacobsj about 2 years ago

  • % Done changed from 0 to 30

I corrected what is listed here, but I think there are some other PHP notices in other areas of the code.

Updated by bsau about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 30 to 60

QS: Pass, partial. I am tempted to close this case, and await further reports of issues of this type.

Developers - what is your opinion?

Updated by tshif over 1 year ago

  • Status changed from Resolved to Closed
  • % Done changed from 60 to 100

Updated by tshif over 1 year ago

  • Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta v 2.2.4 Maintenance Release

scheduled for build 2.2.4

Also available in: Atom PDF