Bug #215
Choose the CLID charset
| Status: | Closed | Start: | 10/26/2009 | |
|---|---|---|---|---|
| Priority: | High | Due date: | 10/26/2009 | |
| Assigned to: | tshif | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta v 2.2.2 Maintenance Release | Estimated time: | 2.00 hours |
Description
ISDN caller ID charset are restricted to IA5.
Some SIP phones will accept extended ASCII charset (my Cisco don't and will write a blank line instead of the CLID if it does contain extended chars).
I would suggest that by default we restrict the charset to IA5 and give an option to the user to extend to ASCII if he know that his phone can support it.
I have uploaded in SVN rev 202 a new callerid.php that uses a variable called $charsetIA5 that is coded as true by default in the code.
We just need to add in the superfecta page a checkbox for to toggle this option and update the database accordingly for this new value.
Related issues
| related to Caller ID Superfecta - Bug #203: source-infobel returns odd characters in CID | Closed | 10/15/2009 | 10/26/2009 | |
| related to Caller ID Superfecta - Bug #208: Infobel odd character | Closed | 10/18/2009 | ||
| related to Caller ID Superfecta - Bug #183: wrong charset do not display foreign characters | Closed | 10/02/2009 | 10/16/2009 | |
| related to Caller ID Superfecta - Bug #219: Choose the CLID charset | Rejected | 10/26/2009 |
History
Updated by patrick_elx over 2 years ago
I don't want to screw up the database and the install/upgrade process. If one of you knows well the way everything is linked together, please jump in to add this checkbox in the scheme general option.
Updated by patrick_elx over 2 years ago
- Status changed from New to QA Testing
- Assigned to set to tshif
svn rev 203, update to previous rev to:
- improve the display in debug mode (reencode in utf8 for display)
- convert html entities returned by a few sources to ascii
Please test this version.
If no bugs are found, I would suggest to release it as is (with the $charsetIA5 forced to true as it should work with all phones).
The ability to choose between IA5 and extended ASCII could be a feature for a future release but is not a priority.
Updated by tshif over 2 years ago
Would the forced IA5 be better in each data source - instead of global?
Updated by patrick_elx over 2 years ago
No, it should be global as it is related to the phones on your PBX not the source you are querying.
Updated by tshif over 2 years ago
I can think of no way to set this on a per-phone basis. Thats where it would be the most effective....
I am leaning to do as you suggest. Release without interface change, hard coded to forced the change. The worst result is that some phones do not use all their capabilltieis, best result is that ALL phones will at least display something.
Updated by tshif over 2 years ago
- Due date set to 10/26/2009
- Status changed from QA Testing to Closed
- Target version set to Caller ID Superfecta v 2.2.2 Maintenance Release
- % Done changed from 50 to 100
QS: Pass Accepted for build 2.2.2
The filter will be hard coded to enabled, pending future releases that expose the setting in the ui.
Updated by jacobsj over 2 years ago
- Status changed from Closed to Reviewed
- Target version changed from Caller ID Superfecta v 2.2.2 Maintenance Release to Caller ID Superfecta - Future Versions
Sorry I've been absent the past couple of weeks...been busy trying to get my house on the market. If anyone is looking to buy a house in the St. Louis area, mine is for sale at 211hawksrest.com :) (website is not 100% complete as of this writing, but will be soon)
Back to business. I'm re-opening this to remind me to implement this feature for the next release.
Couple of thoughts, currently are no completely global variable, the closest they come is variables for an entire scheme. I could added a global variable for this option, but we may want it in individual schemes and here is why:
Admittedly this is a weak argument, but I thought I'd bring it up. Someone could have a set of phones enabled with extended characters sets that are used as part of a call group for international calls, and phones that were meant for US calls. They could have inbound routes and CID schemes set up for those inbound international calls that route to the phones with extended character sets, and use a second CID scheme for inbound calls that go do the IA5 display phones.
Updated by patrick_elx over 2 years ago
It's not a big issue to have it by scheme as long as the value is present with the default setting, it just fill the database.
Also we will have to redo a full source test when IA5 is disabled to make sure that everything is still working properly. My preliminary tests were ok but I haven't done the same extensive debug session than when IA5 was enabled.
Also, right now it's not a fully IA5 compliant filter I've coded, but just a basic accent removal. There are two or three minor differences between ASCII and IA5 and I should implement these changes later on. But I'm not even sure that our phones will see the difference.
By looking at the database and the install/upgrade script, I'm not sure that there's a full cleanup of all the pre-scheme era database info. There may be some unused values that are filled by the script. Maybe need to open a new ticket for that.
Updated by tshif over 2 years ago
- Status changed from Reviewed to Closed
- Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta v 2.2.2 Maintenance Release
This ticket hasbeen closed as part of 2.2.2. I have copied this ticket to a new ticket in `future versions` to document the next phase of this upgrade. Please make no further notations here unless its about 2.2.2.