Caller ID Superfecta

I think that installing only basic sources is ok with a new install, but an upgrade should not delete any source.

Also, it would be nice to be able to select multiple source to download at one time instead of selecting one at a time.

Which one would you include ? Most North-American ones are of no use for me (Europe, Belgium). The ones we use are the cache, Infobel and the Mysql_DB (to get data from our custom application).
So I prefer no defaults, but no delete after update.

I would not include any country specific database.
Only the following: asterisk phone book, trunk provided, superfecta cache

Just to be clear about the deleting, it is currently set up to delete only source files that were not enabled prior to the upgrade. So if a user had 8 sources enabled, those 8 source files would remain, but all others would be deleted. The idea was to reduce clutter in the interface upon install, but keep the sources the user was using prior to the upgrade.

I believe that currently upon install, because of the untarring process, if at the very least we don't include all the sources then every source that isn't included in the install file will be deleted. The user's complaint on the forum speaks to this.

So I guess this is now a two part question:

1. Should we include all the source files so that nothing gets deleted and the users have all the sources they used to use after upgrade?
2. Should we delete unused source files to reduce UI clutter?

I beleive the best answer is to provide an online update capability for the module itself - similar to what we have done with the data sources.

1. We continue to use the FreePBX module controls for initial install, and updates when the changes are significant. I.E;, significant db changes, etc. When install /update is run this way, the module should perform largely as it does right now.

2. For simple patch work cleanups of the nature we are working with now (the open ticket #209), if the module could update itself - or portions of itself, we would have more control over the update process than we do now. In this case, we could replace only the single updated script and xml file (for versioning info).

Also jjacobs said:

Just to be clear about the deleting, it is currently set up to delete only source files that were not enabled prior to the upgrade. So if a user had 8 sources enabled, those 8 source files would remain, but all others would be deleted.

I'm not sure that the behavior we are seeing. I think users are reporting that their previously enabled sources are no longer on the list - and have to be "re-added". When they do this, the settings seems to have been retained, but not their positionin the list of sources.

I just did a test upgrade from 2.1.1 to 2.2.1. none of the selected data soures were retained.
Unknown if this is expected behavior.

tshif wrote:

I just did a test upgrade from 2.1.1 to 2.2.1. none of the selected data soures were retained. Unknown if this is expected behavior.

This is because the 2.2.1 install file does not come with all of the source files as part of the tarball. If you upgrade from 2.1.1 to 2.2.0 the sources will be retained because the source files are part of the install tarball.

What I was attempting to state earlier is that in 2.2.0 all of the source files are part of the install file, and during the install process all of the sources are "installed" or unzipped to the bin folder. Then the install script deletes the sources that are not enabled, leaving the sources that are enabled for the user, so they don't have to download the sources again.

I think the fog over my understanding may be lifting. Essentially - I screwed up by not including all the sources in 2.2.1. sigh So much for my "gold star" in this release!

I think that your installation approach would have worked fine had I just included all the data sources - as you anticipated.

I really do think your current approach is best considering how FreePBX handles the untar when the module is installed/upgraded.

If I (now) understand things correctly - then my intention would be to release 2.2.2 Tuesday with the DID rules fix, and ALL the currently released sources. In this way your install logic will work again as intended. Let me know if you disagree.

Regarding having greater control over the upgrade process, so we don't have to compensate for the FreePBX behaviors upon untar, allowing the module to upgrade itself would mean fine grain control over exactly what happens. Give it some thought. :)

QS: Pass. When not sabotaged by the project admin, the installer works very well.