Bug #209
DID matching
| Status: | Closed | Start: | 10/18/2009 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assigned to: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta v 2.2.2 Maintenance Release |
Description
reported by markiper in the PiaF forum:
Question on DID Schemes ??
I use 2 providers for incoming calls (LES.NET and VITELITY), both of which are passing DID information correctly as 10 digit DID number (I know this for a fact as I am routing incoming calls properly based on DID information).Interestingly enough, when I use the DID number of either provider to establish a DID Scheme on CID Superfecta, the results are not displayed as DID matching cannot be found:
Quote:
DID matching enabled...DID did not match.
Post CID retrieval processing.
Returned Result would be:
result took 0.0489 seconds.
If instead of the 10 digit DID, I use an underscore as the first character of the DID to match, then the results are displayed properly:
Quote:
DID matching enabled...Valid DID.
CID matching enabled...Valid CID: 786NXXXXXX.
Searching Addresses White Pages ... not found
result took 0.8630 seconds.
Searching Google ... not found
result took 0.1650 seconds.
Searching White Pages ... Miami, FL
result took 0.9992 seconds.
Searching Addresses.com Yellow Pages ... not found
result took 1.0940 seconds.
Searching Superfecta Cache ... Miami, FL
result took 0.0023 seconds.
Post CID retrieval processing.
Returned Result would be: Miami, FL
result took 2.0767 seconds.
Any suggestions on this?
History
Updated by patrick_elx over 2 years ago
- Status changed from New to Reviewed
I confirm the issue. The DID matching does not seem to work properly.
Updated by patrick_elx over 2 years ago
- Status changed from Reviewed to Resolved
- % Done changed from 0 to 70
I think I found the bug.
There was a match made only on a 10 digit DID.
Replaced
1 if($thenumber_orig == substr($this_chan_array[7],-10))by
1 if($thenumber_orig == $this_chan_array[7])uploaded to rev 188
Updated by tshif over 2 years ago
- Status changed from Resolved to QA Testing
- Target version set to Caller ID Superfecta v 2.2.1 Maintenance Release
Awaiting Confirmation of fix from users experiencing the issue.
Updated by tshif over 2 years ago
- Target version changed from Caller ID Superfecta v 2.2.1 Maintenance Release to Caller ID Superfecta v 2.2.2 Maintenance Release
Updated by tshif over 2 years ago
The user reporting this issue has not responded to our request to test the fixed code - even though he has been in the forums and musthave seen the request for him to do so.
jjacobs, could you review the changes made and see if you agree with them - in the absence of user testing, this may be validation enough.
Updated by tshif over 2 years ago
Waaaa! I dont wanna. I want it now. now now now. LOL. OK, so your right. :)
Updated by tshif over 2 years ago
markiper Just send me a quick note to let us know hes out of the office till the end of the week. I thanks him for helping by pointing out the bug.
I am open to suggestions for ways we can validate the patch absent folks who can test.
Updated by patrick_elx over 2 years ago
I've tested with different DID (only 10 digits ones) without problem.
I do not have a 11 digits DID.
I will try to experiment tonight with a direct SIP connexion with Zoiper or Xlite to simulate a longer DID.
Updated by patrick_elx over 2 years ago
so far my tests with a simulated 14 digits DID are OK. The DID matching works fine.
Updated by tshif over 2 years ago
- % Done changed from 70 to 90
QS: Pass. DID matching works as anticipated.
Updated by tshif over 2 years ago
- Status changed from QA Testing to Closed
- % Done changed from 90 to 100