Caller ID Superfecta

Little follow up.
Source generated with infobel contains "charset=Windows-1252".
I'm messing around, replacing "$sname = $sname¹[0];" in the source with "iconv ( 'Windows-1252' , 'utf-8' , $sname );" without success, but my knowledge of charsets is limited.

Can anyoneelse have a look ?

1 iconv ( 'Windows-1252' , 'utf-8' , $sname );"

1 $sname = iconv ( 'Windows-1252' , 'utf-8' , $sname );" 

Found the cache problem !
In Infobel the original $thenumber is altered like this :

1 if (strlen($thenumber) > 10)
2         {
3                 if (substr($thenumber,0,2) == '33')
4                 {
5                         $thenumber = '0'.substr($thenumber,2);
6                         $Country = 'FR';
7                 }

When source-Superfecta_Cache.php is called with "$usage_mode == 'post processing'" $thenumber contains the modified number and not the original, so the wrong number is placed in the cache.

Patrick - please review when you have time.
Zorka - have you made these changes in svn as of yet?

Haven't made the changes yet. Need some reading on how to do it first ;-)
svn is new for me.

:) Ok great. Let me know if I can assist -

Im pretty sure we dont have a charsets expert amoung us - certainly not me - but I do think your work with charsets is important.

1 iconv ( 'Windows-1252' , 'utf-8' , $sname );"

should be

1 $sname = iconv ( 'Windows-1252' , 'utf-8' , $sname );"

This may be a big part of the problem with special characters that we currently have with this source. Im looking forward to seeing this fix deployed.

Zorka - do you plan on deploying $sname = iconv ( 'Windows-1252' , 'utf-8' , $sname );"
?

I am anxious to see if this has an impact on spurious charcters in the CID data.

Not yet.... The results just aren't what they should be. Still investigating.
But I committed the cache-thing

QS: Cache bug corrected