Bug #204

Asteridex source lookup

Added by patrick_elx over 2 years ago. Updated over 2 years ago.

Status:Closed Start:10/17/2009
Priority:High Due date:10/26/2009
Assigned to:tshif % Done:

100%

Category:-
Target version:Caller ID Superfecta Source Files

Description

I was browsing through source-AsteriDex.php code and I've noticed the following:

The database login/password is still hard coded in the code.
There is no filter to remove non numeric character in the database and or lookup number.
There is no length option to accommodate the way people are entering the data in the database.

I can easily update the source to correct these issues, however:
I'm not using Asteridex and I will need someone to debug it for me.
Where is the Asteridex database? in the main asterisk one or is it an additional one (ie should I use the generic DB login/password that callerid already use or should I add an option panel for the user to enter his own database info?)

History

Updated by tshif over 2 years ago

  • Status changed from New to Assigned
  • Assigned to set to patrick_elx

patrick_elx wrote:

The database login/password is still hard coded in the code.

Which one is it?

There is no filter to remove non numeric character in the database and or lookup number.

Good catch. It should have this.

There is no length option to accommodate the way people are entering the data in the database.

Again - good catch. It should have this to be consistent with other DB lookups.

I'm not using Asteridex and I will need someone to debug it for me.

Same problem, I dont have it installed - but there are a few folks in the pbxiaf forum using it. Perhaps we can get one or more to test.

Where is the Asteridex database? in the main asterisk one or is it an additional one (ie should I use the generic DB login/password that callerid already use or should I add an option panel for the user to enter his own database info?)

A quick review of the Asteridex install script should answer this. I hope its within the asterisk db - since Im thinking about turning Asteridex into a module, and thats where it has to be once it IS a module.

So - in brief: I agree, make the changes. Im sure we can find at least one person to help us test it.

Updated by patrick_elx over 2 years ago

I hope its within the asterisk db - since Im thinking about turning Asteridex into a module, and thats where it has to be once it IS a module.

Don't you want to work on teleyapper first ;-) I've seen there was some additional work made on this great app in the forum. That would be nice to make it a module and try to organize the collaborative work for it.

Updated by patrick_elx over 2 years ago

  • % Done changed from 0 to 20

Uploaded a tentative fix in rev 186. I don't have Asteridex to try it.
It seems that the database is not a table in asterisk db, but another database...
However I've left the option open for the users to enter what is needed, and I populated them with the default values from the amportal.conf

If you have Asteridex please try this version on your system and report bugs and comments here.

Updated by patrick_elx over 2 years ago

  • Status changed from Assigned to Feedback
  • Assigned to deleted (patrick_elx)

Updated by tshif over 2 years ago

Here is Wards reply.

AsteriDex is a MySQL database. It uses the default MySQL credentials.
--wm

Updated by tshif over 2 years ago

Patrick - Send me your thoughts about teleyapper in email when you have time.

Updated by tshif over 2 years ago

  • Status changed from Feedback to Assigned
  • Assigned to set to patrick_elx

When I install this data source - I see no way to configure it to the database name etc. Was it your intention to expose this as we do in other data sources - to the right of the data source name in the grey config block?

I do not get that behaviour.

Updated by tshif over 2 years ago

Patrick what revision is this update in?

Updated by patrick_elx over 2 years ago

download the latest version ;-)
It was uploaded as rev 186.

Updated by patrick_elx over 2 years ago

  • Assigned to changed from patrick_elx to tshif

Updated by tshif over 2 years ago

  • Status changed from Assigned to QA Testing
  • % Done changed from 20 to 80

QS: Basic Pass. Configurable items present and as expected

Updated by tshif over 2 years ago

  • Due date set to 10/26/2009
  • Status changed from QA Testing to Closed
  • % Done changed from 80 to 100

Added to live update repo.

Also available in: Atom PDF