Bug #202

Test all CID schemes is broken

Added by tshif over 2 years ago. Updated over 2 years ago.

Status:Closed Start:10/14/2009
Priority:Urgent Due date:10/16/2009
Assigned to:tshif % Done:

100%

Category:-
Target version:Caller ID Superfecta v 2.2.1 Maintenance Release

Description

When "test all CID schemes" is selected, it returns only:

Debugging Enabled, will not stop after first result.

And no data whatsoever. This happens regardless of the number of CID schemes present.

History

Updated by jacobsj over 2 years ago

  • Status changed from Assigned to QA Testing
  • % Done changed from 0 to 80

A problem with the MySQL query was causing this. It's fixed now.

Updated by tshif over 2 years ago

  • Assigned to changed from jacobsj to tshif
  • Target version set to Caller ID Superfecta v 2.2.1 Maintenance Release
  • % Done changed from 80 to 90

Updated by tshif over 2 years ago

  • Assigned to changed from tshif to jacobsj

QS: FAIL. Test all CID Schemes is broken. Only the first scheme on the list is tested

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Assigned

Updated by patrick_elx over 2 years ago

mine is working fine.
I've tried to be on any of my scheme page, if I'm checking the box it will try to match the first scheme. If the scheme is not a match, it will go to the next scheme and so on.

If there is a scheme match, it will then test all the enabled source in that scheme and stop at the end of the scheme.

Here's my setup:

1 scheme: From France;
CID rules:
0|33+ZXXXXXXXX
33ZXXXXXXXX
0033ZXXXXXXXX
01133ZXXXXXXXX

2nd scheme: From US;
NXXNXXXXXX
1NXXNXXXXXX
001NXXNXXXXXX
011NXXNXXXXXX

3rd scheme: default
empty CID

debug: 33142887956
Debugging Enabled, will not stop after first result.
Processing From France Scheme.
CID matching enabled...Valid CID: 33142887956.
Searching Asterisk Phonebook ... not found
result took 0.0015 seconds.

Searching Open 79XX XML Directory... not found
result took 0.0024 seconds.

Searching Superfecta Cache ... not found
result took 0.0022 seconds.

Looking for Provided Caller ID ... not found
result took 0.0015 seconds.

Searching Infobel...
FR : not found
result took 1.2411 seconds.

Debug2: 3214567890

Debugging Enabled, will not stop after first result.
Processing From France Scheme.
CID matching enabled...No Matching CID Patterns.
Processing From US Scheme.
CID matching enabled...Valid CID: 3214567890.
Searching Asterisk Phonebook ... not found
result took 0.0013 seconds.

Searching Open 79XX XML Directory... not found
result took 0.0023 seconds.

Searching Superfecta Cache ... not found
result took 0.0023 seconds.

Looking for Provided Caller ID ... not found
result took 0.0015 seconds.

Searching CanPages.ca ... Skipping Source - Non Canadian number: 3214567890
result took 0.0009 seconds.

Searching Google ... not found
result took 0.2122 seconds.

Searching PhoneSpamFilter ... value of 0 returned ... Not a SPAM caller
result took 0.9940 seconds.

Searching Who Called ... not found
result took 0.4579 seconds.

Searching Addresses.com Yellow Pages ... not found
result took 1.1908 seconds.

Searching Telco Data ... COCOA, FL
result took 0.3969 seconds.

Updated by tshif over 2 years ago

Its the debug mode - its supposed to run through all the schemes regarless if there is a match. This is what is not happening. I just tested it, and its really not happening.

Updated by tshif over 2 years ago

(by Patrick)
There's maybe a confusion as to what the test all scheme check box does.

It's to test the CID matching engine, not to test all sources of all scheme.

The problem was that the we were not able to test the CID rules from the debug as it was only called when run from a real call.

The 'test all scheme' is to emulate a number sent to superfecta like if it was a real call to check that the proper scheme is selected due to CID matching (and not DID by the way).

Updated by tshif over 2 years ago

  • Status changed from Assigned to QA Testing
  • Assigned to changed from jacobsj to tshif

Now that I have my brain on straight (Thanks Patrick), we will test and release the module today.

Yay!!

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Closed
  • % Done changed from 90 to 100

Test all schemes works as expected.

Also available in: Atom PDF