Caller ID Superfecta

Thank you Jonathan!

Nixi (Jonathon) has been `promoted` to developer status on the SUperfecta Module.
Patrick - when time permits - will you do a quick check over this new source - highlight any thing that needs changing (to follow current standards) and share your findings with Nixi - I'm sure he'll want to fix his own submitted code now that he has SVN write access.

The sooner hes up to speed on coding standards - the sooner the project gets another talented volunteer developer to pitch in!

Welcome aboard Nixi!

uploaded to svn rev 170.

The code was already up to date with the latest improvements.

However it seems that this website is also storing numbers from outside Sweden.
Should we let all numbers reach this source and just format them properly (with the leading 00+country code if not from Sweden)?

Please advise.

It seems at first glance like that would be a good idea. This source would probably be faster for folks in that region. It could be prioritized in various schemes and within the schemes as well.

I dont see a down side off the top of my head. Other thoughts from other people?

This has been added to the live update repo. We can always update it again if we determine to modify this source as Patrick posed a question about here

patrick_elx wrote:

uploaded to svn rev 170.

The code was already up to date with the latest improvements.

However it seems that this website is also storing numbers from outside Sweden. Should we let all numbers reach this source and just format them properly (with the leading 00+country code if not from Sweden)?

Please advise.

I would suggest that we let all numbers to this source because as you said it actually contains some numbers from outside Sweden. Would it be correct to remove all the code that was introduced with #187?

I think I got a Subversion client now set up correctly on my Ubuntu and I could do it but please ok first.

I'm ok with this idea. Go ahead and make the change to this data source. Good luck with your first svn access.

QS: Pass. No negative results noted from installation of the updated data source.
Unable to generate any hits, but the data source appears to be operating as intended.

Accepted into the live update repository.

Just be aware that this source does not accept anymore international format number (except for numbers out of SE), and all SE numbers needs to be sent with the national format only.

I would suggest that a filter is still needed to be consistent with other sources.

check rev 198 for updated file.

Also, I'm not sure that the SPAM_threshold is doing anything. I don't understand Swedish, but I haven't seen anything on the page regarding the threshold option in the url
$url="http://api.vemringde.se/?q=$thenumber&e=1&n=".$run_param['SPAM_Threshold']."";

I've tried to play with different level in the debug and always had a SPAM return.

Should we remove the threshold option as a whole for this source?

Patrick, please make both changes. I have removed the data source from live update untill you tell me its ready.

please check rev 198 for QA.
I've left the spam threshold as it is not blocking. It's just maybe a useless option. We can always remove it later if it's confirmed that its not doing anything.

sorry, check rev 184 (not 198)

patrick_elx wrote:

please check rev 198 for QA. I've left the spam threshold as it is not blocking. It's just maybe a useless option. We can always remove it later if it's confirmed that its not doing anything.

The spam threshold does work when I have tested. You can easily try to change the value to something very high like 5000 and you will most likely not get any results. Remember that Sweden is a small country;-) If the "n" parameter is left out the vemringde.se database will default to 5 just to not show single records that might be wrong.

Good then if the threshold works, but if you achieve to have more info on what the value means that would be great. For phonespam it's the number of person who reported this number as spam.

Please check if the source is still working fine for you with the filters I put. Also if you can have a look at the website to see if all foreign source are consistently reported with a 00+country code or not.
Also are the local Swedish number reported with all the digits (I've seen that there are some SMS numbers too with only 5 digits on the list)
If so, I can probably add another filter for foreigns number to replace 011 by 00, or add 00 if there's not enough digits to make it look like a foreign source.

patrick_elx wrote:

Good then if the threshold works, but if you achieve to have more info on what the value means that would be great. For phonespam it's the number of person who reported this number as spam.

Please check if the source is still working fine for you with the filters I put. Also if you can have a look at the website to see if all foreign source are consistently reported with a 00+country code or not. Also are the local Swedish number reported with all the digits (I've seen that there are some SMS numbers too with only 5 digits on the list) If so, I can probably add another filter for foreigns number to replace 011 by 00, or add 00 if there's not enough digits to make it look like a foreign source.

The threshold is exactly the same as for phonespam.

The numbers in the database are not stored in an consistent way. It is a big mess in a way. Most numbers are in the format of area code (2-4 digits) and then the number itself (5-7 digits). I guess they started the database by just letting people enter what ever they liked and with no checks on the database side.

For me it is fine as it is. It works as expected. I have it myself as the last source in my list.

Ok - so If I understand this source - its for SPAM scoring, and is a low qulaity source due to the inconsistecies in the database. DO I have this correct so far?

Nixi - you feel the code is ready for release - am I correct in thinking this?

Patrick - what is your opinion?

In short - who has next action, and what is next action. Software test and release, or more work?

For me the code seems fine.
I was just wondering if the spam value was valid or not. But it seems that it is.

I'll vote for GO.

Yes it is for spam scoring. It works fine for me with my testing. Luckily nobody that has called me has been on the list yet;-)

I will second the vote for GO!

Go concensus has been reached by the principle dev involved. Accepted and posted to live update repository.