Feature #194

Add $source_param['Option Name']['default'] in the lookup sources

Added by patrick_elx over 2 years ago. Updated over 2 years ago.

Status:Closed Start:10/11/2009
Priority:High Due date:10/16/2009
Assigned to:tshif % Done:

100%

Category:-
Target version:Caller ID Superfecta v 2.2.1 Maintenance Release Estimated time:0.50 hour

Description

It would be nice to be able to define a default value for some optional parameters in the lookup source.
Now, when you install a new source, all the optional fields are blank.

I would suggest that we update sources.php to accept an additional param called default to set the initial default value in the database as it could break some sources if they are not set up properly.

right now we have:
$source_param['Option Name']['desc']
$source_param['Option Name']['type']

I would add a
$source_param['Option Name']['default']

I'm not sure about how exactly doing it in sources.php as I'm not a php/sql guru.

History

Updated by tshif over 2 years ago

I tend to agree. In cases where a config item left blank can create a fault in the system - defaults really should be provided.

Updated by tshif over 2 years ago

  • Status changed from New to Reviewed

Updated by jacobsj over 2 years ago

  • Status changed from Reviewed to QA Testing
  • % Done changed from 0 to 80

Easy enough to implement. It has been added and I updated the source for Trunk Provided with an example.

Implement in other sources as you see fit.

Updated by jacobsj over 2 years ago

  • Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta v 2.2.1 Maintenance Release

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Assigned
  • Assigned to set to patrick_elx
  • % Done changed from 80 to 50

Patrick - you have the best familiarity with the data source scripts. Will you take this task?

Updated by patrick_elx over 2 years ago

  • Status changed from Assigned to QA Testing
  • % Done changed from 50 to 90
  • Estimated time set to 0.50

done in rev 168

Updated by tshif over 2 years ago

  • Assigned to changed from patrick_elx to tshif

Updated by tshif over 2 years ago

  • Due date set to 10/16/2009
  • % Done changed from 90 to 100

QS: Pass. No negative results detected from these upgrades. Data sources with configurable setting now come with defaults to prevent needless data source failure from incomplete user configuration.

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Closed

Accepted for build 2.2.1

Also available in: Atom PDF