Bug #192
Infobel and DE, AU, ES, IT
| Status: | Closed | Start: | 10/08/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | 10/16/2009 | |
| Assigned to: | patrick_elx | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta Source Files |
Description
I've added the DE, AU, ES, IT source lookup in source-infobel in rev 160 thanks to PIAF forum HarryHirsh, however I have some trouble with these countries as some names are not being extracted correctly from the infobel webpage result.
I've uploaded it to let Harry and others to look at it.
History
Updated by tshif over 2 years ago
Only registered users have access to the SVN. Perhaps you should attachit to this ticket - thats public.
Updated by jacobsj over 2 years ago
Actually, I can checkout the SVN for this project anonymously. I cannot however submit changes. Anyone should be able to checkout the SVN and look at the latest source. Not sure if that's expected behavior for this redmine system.
Updated by tshif over 2 years ago
Actually - I do remember having this discussion before. And I beleive the front page says somethign like "write access to the svn is given only to registered developers".
Looks like I was remembering the early days of our journey here together. Cause Im pretty sure your rigght - its been this way since then.
So - Ill open this to the floor - do you agree with this open svn download policy? Id like to know what you and Patrick think.
Sooo - OOOOPS. Patrick, Nevermind about the whole attachment thing. LOL..(Red faced)
Updated by tshif over 2 years ago
SOmeone started a forum discussion about italian sources. I just noticed it was there - LOL. Drop by if your interested.
Updated by tshif over 2 years ago
- Status changed from New to Reviewed
Updated by tshif over 2 years ago
Patrick - since this version of this source is broken, what SVN Rev version should be used for 2.2.1 - assuming this bug is not fixed in time for release of 2.2.1?
Updated by patrick_elx over 2 years ago
It's not broken per se. The previous countries are working fine. Just the new ones I tried to add are not responding properly but are not breaking anything else.
I also did not add these new countries in the list you see on the option help text.
Then if nobody is looking at the source, they wont know that there are new countries coded.
Even if they are sending a properly formated number for these countries, they just will have a false negative with no caller ID returned while there may be an answer on the webpage.
You can use the latest rev, at least if someone is looking at it they'll maybe fix it ;-)
Updated by tshif over 2 years ago
- Assigned to set to patrick_elx
- Target version changed from Caller ID Superfecta Source Files to Caller ID Superfecta - Future Versions
Patrick - I agree to leaving this version (partiallybroken) in the 2.2.1 build.
Would you make comments in the current source around the parts of the code that do not work - so that anyone looking will understand that we know it doesnt work - and needs fixing?
Once thats done - well run with the current version.
Updated by patrick_elx over 2 years ago
I've made a comment in the header of the file in rev 168. But with the online update feature, we won't have to wait too long to be able to push an upgrade on this source when we'll fix it.
I'm hopping Harry will be able to help us with it as he's done a lot of work with this source.
Updated by tshif over 2 years ago
- Due date set to 10/16/2009
- Status changed from Reviewed to Closed
- Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta Source Files
- % Done changed from 0 to 100
QS: Passed, as noted in this thread (known limitations)