Bug #191

Update site not available message does not display when site is in maintenance mode

Added by tshif over 2 years ago. Updated over 2 years ago.

Status:Closed Start:10/05/2009
Priority:High Due date:10/16/2009
Assigned to:tshif % Done:

100%
Category:-
Target version:Caller ID Superfecta v 2.2.1 Maintenance Release

Description

Update site not available message does not display when the update site is not available. Fixed by jjacobs

Condition 1 Still exists:
#When the update site is in actual maintenance mode, all data sources get flagged as 'unsupported module'.
Also - the new red `site unavailable` message is not displayed.

Additional information:

When the site IS in the actual maintenance mode, it delivers this exact content to the browser:

<html>
<head>
<title>System Maintenance In Progress</title>
</head>
<body>
The system is currently in Maintenance Mode. Please try again later.
</body>
</html>

I think the desired behaviour would be the same as when the site does not respond at all - ie; The red message.

maintenancemode.txt - Maintenance mode source capture (174 Bytes) tshif, 10/12/2009 03:06 pm

History

Updated by tshif over 2 years ago

  • Target version set to Caller ID Superfecta v 2.2.1 Maintenance Release

Updated by tshif over 2 years ago

Ok - here are some more details about the behaviour of the module when the live update site is not available, and the user has enebaled `check for data source file updates online`

  1. When the update site is in actual maintenance mode, all data sources get flagged as 'unsupported module'.
  2. When the update site is unreachable, the checkmark box for `check for data source file updates online` is turned off, and no "site unavailable" message is seen.

For condition 1, since the dev site returns the message "... currently in maintenance mode..." (not exact quote) when it is down for actual maintenance. Perhaps themodule could look for that and return the message to the UI?

For condition 2, is that expected behavior?

Updated by tshif over 2 years ago

  • Assigned to set to jacobsj

Updated by jacobsj over 2 years ago

  • Status changed from New to QA Testing
  • % Done changed from 0 to 80

I forgot that AJAX doesn't properly run new javascript, so the error message wasn't displaying properly. I resorted to some red font. We should get an appropriate error message now, though not as "in your face" as a javascript alert.

Updated by tshif over 2 years ago

  • Subject changed from Update site not available message does not display when the update site is not available to Update site not available message does not display when site is in maintenance mode

QS: Partial Pass. Red warning is NOW displayed when site is unreachable.
However, the maintenace mode is not detected and handled correctly.

Updated by jacobsj over 2 years ago

I just committed a change that should result in the same unavailable message when the site is in maintenance mode. I have not seen the maintenance mode message, but assuming there are no carriage returns beyond the ones in the HTML that Tony posted above, then the unavailable message should be triggered by the site being in maintenance mode now.

Updated by tshif over 2 years ago

  • Assigned to changed from jacobsj to tshif

Updated by tshif over 2 years ago

QS: FAILED. Still shows unsupported modules for all when site in maintenance mode, no red warning.

I have formatted the page results a little differently below - perhaps the previous version was not exact in some way. I'm using the PRE format tags for this cut and paste.

Sorry for the extra Work Jeremy -

<html>
    <head>
        <title>System Maintenance In Progress</title>
    </head>
    <body>
        The system is currently in Maintenance Mode. Please try again later.
    </body>
</html>

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Assigned
  • Assigned to changed from tshif to jacobsj

Updated by jacobsj over 2 years ago

Tony, can you save a copy of the site in maintenance mode into a txt or html file and attach it to this ticket?

Updated by tshif over 2 years ago

I Will sure try. The only way I have found it was to `view source` for the page when displayed in a browser. I am not sure doing that into an attachment will give you what you really are looking for.

Would it help if you could see the page? I can go to maintenance mode for you at any time - or give me a suggestion about the best way to get what you really need.

I have not bee successfull in scanning the file system for an HTM file -

Updated by tshif over 2 years ago

Attached maintenance mode page for jjacobs

Updated by jacobsj over 2 years ago

It would help if I used the strpos function properly and put the haystack and needle in the proper locations...try maintenance mode again and make sure that this works now. It should now that I've used the function properly.

Updated by tshif over 2 years ago

  • Status changed from Assigned to QA Testing
  • Assigned to changed from jacobsj to tshif

Updated by tshif over 2 years ago

  • Status changed from QA Testing to Assigned
  • Assigned to changed from tshif to jacobsj

QS: Partial Pass.
The site maintenance state is now correctly recognized, and the red error message is displayed.

When the red message is diplayed becuase the site does not respond at all - the red message stays visible untill the user clicks the next thingin the user interface.

When the red message is diplayed becuase the site is in maintenance mode - the red message disappears immediately, and may not be noticed by the operator.

Goal: When in maintenance ode, make the red message stay untill the next thing is clicked just as it works when the site is unresponsive.

Updated by jacobsj over 2 years ago

there should be no difference between maintenance mode and the site being down. They both use the exact same set of code and should behave in the exact same manner. Can you double check that the behavior is different?

Updated by tshif over 2 years ago

You are correct - I did a poor job of understanding and documenting the problem.

The red warning message is displayed, and stays on the screen as expected when updates are checked for by clicking on the DEBUG button.

The red warning message is displayed, but disappears immediately when updates are checked for by clicking on any data source name.

This problem occurs in IE8.
The problem does not occur in firefox. I think this is due to the fact that in firefox, simply clicking the check mark box to check for updates actually initiates the update check, but in IE, you have to click either debug or a source name to trigger the update.

Updated by jacobsj over 2 years ago

Ok, I went from an "onchange" event handler on the checkbox to "onclick" because IE only processes onchange when the element losses focus. Onclick should make the update process happen immediately. One downside to this approach is that onclick does not run if the user has tabbed to the element and uses the keyboard to check the box because onclick only works for mouse clicks.

Updated by tshif over 2 years ago

  • Status changed from Assigned to QA Testing
  • Assigned to changed from jacobsj to tshif

Updated by tshif over 2 years ago

  • Due date set to 10/16/2009
  • Status changed from QA Testing to Closed
  • % Done changed from 80 to 100

QS: Pass. Site unavailable message works as expected.

Also available in: Atom PDF