Bug #190
DID matching
| Status: | Closed | Start: | 10/04/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | 10/16/2009 | |
| Assigned to: | tshif | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta v 2.2.1 Maintenance Release |
Description
By looking at the code of caller_id.php I was wondering if the following could not create a bug:
the CID provided by asterisk in the http request [thenumber] is used to match the channel used (via asterisk manager) to find the DID.
However, before doing the match, we are transforming the number with
$thenumber_orig = ereg_replace('[^0-9]+', '', $thenumber_orig);
In some cases, where the CID did contain letters, then the match with a channel will not work anymore.
If I'm right, I would suggest the following mod:
remove the line $thenumber_orig = ereg_replace('[^0-9]+', '', $thenumber_orig);
and change the line $thenumber = $thenumber_orig;
by
$thenumber = ereg_replace('[^0-9]+', '', $thenumber_orig);
Please advise if this indeed is a problem or not and if I should submit this patch.
History
Updated by tshif over 2 years ago
- Status changed from New to Feedback
- Assigned to set to jacobsj
Id like to hear from Jeremy on this - and anyone else interested.
Updated by jacobsj over 2 years ago
- Status changed from Feedback to QA Testing
- % Done changed from 0 to 80
Your suggestion seems reasonable Patrick so I went ahead and implemented it.
Updated by tshif over 2 years ago
- Assigned to changed from jacobsj to tshif
Updated by tshif over 2 years ago
- Due date set to 10/16/2009
- Status changed from QA Testing to Closed
- Target version set to Caller ID Superfecta v 2.2.1 Maintenance Release
- % Done changed from 80 to 100
QS: PASS. No negative results - appears to function as desire