Bug #19
Significant Module restructure and upgrade
| Status: | Closed | Start: | 05/01/2009 | |
|---|---|---|---|---|
| Priority: | Urgent | Due date: | ||
| Assigned to: | jacobsj | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Caller ID Superfecta v 2.0.0 | Estimated time: | 4.00 hours |
Description
Add source PhoneSpamFilter, Addresses, and Yellow Pages to the module.(5-6-2009)
Include debug, timeout, getcontent, offset, and maxlen configuration items in the webui.
Validate current SugarCRM source will still work with the new callerid.php architecture and debug methods introduced by Ward's most recent callerid.php script.(5-6-2009)
These changes will also cover the previous bug concerning the whitepages bug (returns a comma for textual caller id data.) http://projects.colsolgrp.net/issues/show/3
- DB Schema update.
New status fields for each source must be added.(5-6-2009)The Debug parameter is being moved to the Module ui. New DB field is required.(5-6-2009)A new timeout parameter is being moved to the Module ui. New DB field is required.(5-6-2009)- A new getContent parameter is being moved to the Module ui. New DB field is required.
- A new offset parameter is being moved to the Module ui. New DB field is required.
- A new maxlen parameter is being moved to the Module ui. New DB field is required.
- Module WebUI update.
New status fields and prompts for each source must be added.(5-6-2009)The Debug parameter is being moved to the Module ui. A new status field and prompt are required.(Split to Ticket #36)A new timeout parameter is being moved to the Module ui. A new status field and prompt are required.(5-6-2009)- A new getContent parameter is being moved to the Module ui. A new status field and prompt are required.
- A new offset parameter is being moved to the Module ui. A new status field and prompt are required.
- A new maxlen parameter is being moved to the Module ui. A new status field and prompt are required.
- Install.php must be able to sense the need for and handle db schema updates.
Method to sense the presence of key fields to determine the db schema revision, and extend the schema as required is needed.(5-6-2009)Default values may need to be provided for some of the new fields, for example the debug variable should be set to 0 by default during install, and not left as empty or null.(5-6-2009)
Existing installed versions of the module must have the DB schema extended to include the new fields.(5-6-2009)
The current SugarCRM integration need to be included in the new version, and may need adjustment depending upon some nuts and bolts which Uncle Ward may have made to the new code base we are adopting.(5-6-2009)
Related issues
| related to Caller ID Superfecta - Bug #3: Superfecta sometimes returns a comma instead of text Caller ID info | Closed | 04/25/2009 | ||
| related to Caller ID Superfecta - Feature #10: Be Able to apply dynamic prefixes by using a URL | Closed | 04/28/2009 | ||
| related to Caller ID Superfecta - Bug #17: <!DOCTYPE HTML caller ID on incoming calls | Closed | 04/29/2009 | ||
| related to Caller ID Superfecta - Feature #30: Streamline Module http authentication | Closed | 05/04/2009 | ||
| related to Caller ID Superfecta - Feature #7: Be able to prioritize search sources | Closed | 04/27/2009 |
History
Updated by bsau about 4 years ago
- Estimated time set to 3.00
Updated by bsau about 4 years ago
- Tracker changed from Feature to Bug
Updated by tshif about 4 years ago
- Status changed from New to Feedback
Changed to FEEDBACK status while the feature set is being determined and locked for 1.1.2.
Updated by tshif about 4 years ago
- Assigned to set to tshif
This may be the best way to get the needed maintenance release out the door.
Updated by tshif about 4 years ago
- Target version changed from 6 to Caller ID Superfecta v 2.1.0
Updated by tshif about 4 years ago
- Target version changed from Caller ID Superfecta v 2.1.0 to 6
- Estimated time changed from 3.00 to 4.00
Updated by jacobsj about 4 years ago
- % Done changed from 0 to 20
Updated by jacobsj about 4 years ago
- File superfecta-1.2.1.tgz added
Ok,
I got impatient and did most of the upgrades...I figured while I worked on importing the latest sources, I might as well implement a bunch of other changes.
I haven't committed these because of the large step forward, and I didn't want to step on anyone's toes.
Please download the file and install, and verify this is the direction we want to go. the UI still needs a little tweaking, but everything should be functional.
This has curl enabled with user difinable timeouts.
The user is able to select the order they want to query sources
Adding new sources is as simple as adding new files named source-[name_of_source].php to the bin folder. No other code changes need to be made, the system will recognize the addition of a new source.
A Prefix system is added now: specify a url like http://example.com/get_order_number.php?phone_number=[thenumber]
Test and let me know if you want me to commit all these changes to the system.
Updated by tshif about 4 years ago
jacobsj wrote:
Ok,
I got impatient and did most of the upgrades...I figured while I worked on importing the latest sources, I might as well implement a bunch of other changes.
This makes perfect sense to me. I have been thinking the same thing - but didn't feel competent to handle some of the tasks. Because of the nature of the structural changes - the db changes, etc - it seems a situation where much of it should be done at the same time.
I haven't committed these because of the large step forward, and I didn't want to step on anyone's toes.
You did this in the perfect way - by making it an attachment we can all get at it, but the public can not. Also - I think as a matter of form the project manager/admin person should has this kind of sign-off. I also added the "reviewed" status to tickets primarily for the manager of each project to use when they formally receive the ticket - but before any decisions on it are made. Besides - I have strong toes! Have no fears
Please download the file and install, and verify this is the direction we want to go. the UI still needs a little tweaking, but everything should be functional.
The sorting function seems to be broken. Only the top two change positions. Should this be spun of into a separate ticket?
This has curl enabled with user definable timeouts.
And the ui has a place to change it. Nice.
The user is able to select the order they want to query sources
Broken I think.
Adding new sources is as simple as adding new files named source-[name_of_source].php to the bin folder. No other code changes need to be made, the system will recognize the addition of a new source.
Excellent - some theory of operation. When we create the docuemnts for the site, we can add these details to it. very Cool. I couldn't quite figure out what you had in mind here. This is a really great way to handle extensibility moving forward. Your design is simple and elegant and a perfect fit for the goal as it was stated.
A Prefix system is added now: specify a url like http://example.com/get_order_number.php?phone_number=[thenumber]
Hmmm. This will be interesting to test.
Test and let me know if you want me to commit all these changes to the system.
My suggestion would be to look into the sort order problems I reported, and then commit. This is exactly the direction we should go.
-thif
Updated by tshif about 4 years ago
Updated Ticket description to reflect progress on many of the goals.
Updated by tshif about 4 years ago
dbschema update items 4,5, & 6 and Module WebUI update items 4,5, & 6 were not addressed i the current round of update work. These were from the time when we planned on using Wards new codebase. If they are not longer required in the new code base (as I suspect) - they should be stricken in the main ticket description.
Module WebUI update item #2 was not addressed in the current round of update work. Do you have concerns with this goal?
Updated by tshif about 4 years ago
Added completion dates to goal statements. All work completed on (5-6-2009) provided by jacobsj.
Updated by tshif about 4 years ago
- Status changed from Feedback to Assigned
- Assigned to changed from tshif to jacobsj
- % Done changed from 20 to 80
Updated by tshif about 4 years ago
The new version was simply more sophisticated than the tester (me) Deselected (disabled) sources do not participate in the sort behavior. The ordering code works perfectly.
I do have a question though - what about this Issue #28 request? Would now be a good time to add that since you are working on the structure in that general area?
Updated by tshif about 4 years ago
- Subject changed from Add 3 new sources to Superfecta Module to Significant Module restructure and upgrade
Updated by jacobsj about 4 years ago
- Status changed from Assigned to Closed
- % Done changed from 80 to 100
Updated by jacobsj about 4 years ago
- Target version changed from 6 to Caller ID Superfecta v 2.0.0