Feature #177

PhoneSpamFilter (UK) Support

Added by chrisb over 2 years ago. Updated over 2 years ago.

Status:Closed Start:09/30/2009
Priority:Urgent Due date:
Assigned to:patrick_elx % Done:

100%
Category:-
Target version:Caller ID Superfecta Source Files

Description

Guys,

I would appreciate if you would accept the modified of the PhoneSpamFilter source that is modified (slightly) to work with the UK version of the site (and support UK NPAs).

Please include with future version of SuperFecta.

Many thanks.
Chris Bailes.

source-PhoneSpamFilter_UK.tar - source file to incorporate UK version of the PhoneSpamFilter website (20 KB) chrisb, 09/30/2009 09:25 am

History

Updated by patrick_elx over 2 years ago

  • Status changed from New to Reviewed
  • Target version changed from Caller ID Superfecta v 2.2.0 to Caller ID Superfecta Source Files
  • % Done changed from 100 to 80

I've uploaded for testing as rev 132 in the SVN.
I've tested it with a DID I have with UKDDI (02032xxxxxx) but it's not in your list of STD/NGN.
By the way what does STD and NGN mean? I'm not familiar with the UK numbering scheme.

Updated by tshif over 2 years ago

  • Status changed from Reviewed to Feedback

To make sure Im clear on the updated file - it is designed to work in both the UK and US? Or is it to be a UK specific datasource?

Updated by tshif over 2 years ago

  • Assigned to changed from admin to tshif

Updated by patrick_elx over 2 years ago

By looking at the code that's a UK specific source

Updated by tshif over 2 years ago

Tested by forum user TDF with tese results:

I gave the UK source a go with the debug tool, out of 13 numbers currently in my blacklist 3 were marked spam and one more had a count of 3 so didn't make it due to me setting the threshold at 3.

Interestingly http://whocallsme.com/ had 12 out of 13, just saying lol.

Sounds like a good experience - Id like to get another test or two before posting this source to the autoupdate location. Anyone else?

Updated by tshif over 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

This data source is now available via the built in Superfecta data Source update function. Thanks Chris!

Updated by tshif over 2 years ago

  • Status changed from Closed to Assigned
  • Assigned to changed from tshif to patrick_elx
  • Priority changed from Normal to Urgent
  • % Done changed from 100 to 90

Patrick - I think this code has the '$number_error was not reinitialized' - can you check and see if it needs your fix? If so let meknow - as I posted the original version already.

Updated by patrick_elx over 2 years ago

  • Status changed from Assigned to Resolved

good catch.
fixed by rev 133

Updated by tshif over 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

New build posted to live update function. Thanks Patrick.

Also available in: Atom PDF