Feature #161

Checking the proper format of data returned to asterisk

Added by patrick_elx over 2 years ago. Updated over 2 years ago.

Status:Closed Start:06/29/2009
Priority:High Due date:
Assigned to:- % Done:

100%
Category:-
Target version:Caller ID Superfecta v 2.2.0

Description

When a source failed or some other poisoning of the data in the CLID happened, the CLID returned to asterisk can contain some non authorized characters or html code.

When presented with these long weird caller ID, the extension will refuse it and the call will jump to voicemail.

I would suggest that before returning to asterisk, a check of the string is done to remove all non authorized character and maybe cut long strings.

History

Updated by patrick_elx over 2 years ago

  • % Done changed from 0 to 20

proposed a solution in rev 110.

//remove unauthorized character in the caller id
$first_caller_id = preg_replace ( "/[\";']/", "", $first_caller_id);

//limit caller id to the first 60 char
$first_caller_id = substr($first_caller_id,0,60);

Please test on your system and look if more (or less) character should be removed

Updated by tshif over 2 years ago

  • Status changed from New to Feedback

This could solve the serious issue raise by patrick. Caller ID should not have the ability to tank the phone system. jjacobs should be back from holiday soon - and I'm quite sure he will chime in on several of these structure and design discussions.

Updated by jacobsj over 2 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 20 to 100

Implementing Patrick's proposed fix.

Updated by jacobsj over 2 years ago

  • Status changed from Resolved to Closed

Updated by jacobsj over 2 years ago

  • Target version changed from Caller ID Superfecta - Future Versions to Caller ID Superfecta v 2.2.0

Also available in: Atom PDF